v0.3.14-pre.008-fix.002
This commit is contained in:
@@ -1,12 +1,12 @@
|
||||
# file: Cargo.toml
|
||||
# version: 577
|
||||
# version: 578
|
||||
|
||||
[workspace]
|
||||
resolver = "3"
|
||||
members = ["crates/ksp-app-backfill-desk", "crates/ksp-app-config-desk", "crates/ksp-app-solprices-desk", "crates/ksp-app-store-desk", "crates/ksp-app-wallet-desk", "crates/ksp-config-lib", "crates/ksp-core-lib", "crates/ksp-interface-lib", "crates/ksp-job-api", "crates/ksp-job-backfill-lib", "crates/ksp-logging-lib", "crates/ksp-offchain-transport-lib", "crates/ksp-onchain-transport-lib", "crates/ksp-program-api", "crates/ksp-raw-transaction-lib", "crates/ksp-store-api", "crates/ksp-store-lib", "crates/ksp-store-postgres-lib", "crates/ksp-wallet-lib", "crates/ksp-worker-api", "crates/ksp-worker-raw-transaction-ingest-lib"]
|
||||
|
||||
[workspace.package]
|
||||
version = "0.3.14-pre.8.fix.1"
|
||||
version = "0.3.14-pre.8.fix.2"
|
||||
edition = "2024"
|
||||
license = "MIT"
|
||||
repository = "https://git.sasedev.com/Sasedev/khadhroony-solana-project"
|
||||
|
||||
@@ -158,15 +158,11 @@ impl RawTransactionIngestLiveSource {
|
||||
(true, false, false, http_block_scan, true)
|
||||
},
|
||||
Self::HttpBlockPolling(source) => {
|
||||
let known_reference_hydration = match http_role_supports_rpc_method(
|
||||
&source.http_pool,
|
||||
&source.polling_role,
|
||||
"getTransaction",
|
||||
source.network.as_str(),
|
||||
) {
|
||||
std::result::Result::Ok(value) => value,
|
||||
std::result::Result::Err(error) => return std::result::Result::Err(error),
|
||||
};
|
||||
let known_reference_hydration =
|
||||
match http_role_supports_rpc_method(&source.http_pool, &source.polling_role, "getTransaction", source.network.as_str()) {
|
||||
std::result::Result::Ok(value) => value,
|
||||
std::result::Result::Err(error) => return std::result::Result::Err(error),
|
||||
};
|
||||
(false, true, false, true, known_reference_hydration)
|
||||
},
|
||||
Self::StandardBlock(_) => (false, true, false, false, false),
|
||||
@@ -230,21 +226,13 @@ impl RawTransactionIngestLiveSource {
|
||||
tokio::sync::watch::channel(crate::RawTransactionIngestProcessingFrontierProjection::empty());
|
||||
let mut source_future = std::boxed::Box::pin(async move {
|
||||
return match self {
|
||||
Self::HeliusTransaction(source) => {
|
||||
source.run(settings, stop_receiver, admission_sender, source_frontier_sender, shared).await
|
||||
},
|
||||
Self::HeliusTransaction(source) => source.run(settings, stop_receiver, admission_sender, source_frontier_sender, shared).await,
|
||||
Self::HttpBlockPolling(source) => {
|
||||
source
|
||||
.run(settings, stop_receiver, admission_sender, source_frontier_sender, shared.continuity_contracts)
|
||||
.await
|
||||
source.run(settings, stop_receiver, admission_sender, source_frontier_sender, shared.continuity_contracts).await
|
||||
},
|
||||
Self::StandardBlock(source) => source.run(settings, stop_receiver, admission_sender, source_frontier_sender).await,
|
||||
Self::StandardLogs(source) => {
|
||||
source.run(settings, stop_receiver, admission_sender, source_frontier_sender, shared).await
|
||||
},
|
||||
Self::Yellowstone(source) => {
|
||||
source.run(settings, stop_receiver, admission_sender, source_frontier_sender, shared).await
|
||||
},
|
||||
Self::StandardLogs(source) => source.run(settings, stop_receiver, admission_sender, source_frontier_sender, shared).await,
|
||||
Self::Yellowstone(source) => source.run(settings, stop_receiver, admission_sender, source_frontier_sender, shared).await,
|
||||
};
|
||||
});
|
||||
loop {
|
||||
@@ -825,12 +813,8 @@ impl crate::RawTransactionIngestYellowstoneSource {
|
||||
processing_frontier_sender: tokio::sync::watch::Sender<crate::RawTransactionIngestProcessingFrontierProjection>,
|
||||
shared: RawTransactionIngestSourceRuntimeShared,
|
||||
) -> ksp_core_lib::Result<()> {
|
||||
let RawTransactionIngestSourceRuntimeShared {
|
||||
continuity_contracts,
|
||||
global_hydration_registry,
|
||||
hydration_in_flight_limit,
|
||||
hydration_pending_limit,
|
||||
} = shared;
|
||||
let RawTransactionIngestSourceRuntimeShared { continuity_contracts, global_hydration_registry, hydration_in_flight_limit, hydration_pending_limit } =
|
||||
shared;
|
||||
let opened = tokio::select! {
|
||||
biased;
|
||||
_ = stop_receiver.changed() => {
|
||||
@@ -1071,12 +1055,8 @@ impl crate::RawTransactionIngestHeliusTransactionSource {
|
||||
processing_frontier_sender: tokio::sync::watch::Sender<crate::RawTransactionIngestProcessingFrontierProjection>,
|
||||
shared: RawTransactionIngestSourceRuntimeShared,
|
||||
) -> ksp_core_lib::Result<()> {
|
||||
let RawTransactionIngestSourceRuntimeShared {
|
||||
continuity_contracts,
|
||||
global_hydration_registry,
|
||||
hydration_in_flight_limit,
|
||||
hydration_pending_limit,
|
||||
} = shared;
|
||||
let RawTransactionIngestSourceRuntimeShared { continuity_contracts, global_hydration_registry, hydration_in_flight_limit, hydration_pending_limit } =
|
||||
shared;
|
||||
let connected = tokio::select! {
|
||||
biased;
|
||||
_ = stop_receiver.changed() => {
|
||||
@@ -1489,9 +1469,7 @@ impl crate::RawTransactionIngestHttpBlockPollingSource {
|
||||
break 'source;
|
||||
}
|
||||
}
|
||||
if !blocked_by_null
|
||||
&& let std::option::Option::Some(proven_end_slot) = discovery.proven_end_slot
|
||||
{
|
||||
if !blocked_by_null && let std::option::Option::Some(proven_end_slot) = discovery.proven_end_slot {
|
||||
let coverage_result = {
|
||||
let mut contracts = match continuity_contracts.lock() {
|
||||
std::result::Result::Ok(value) => value,
|
||||
@@ -1882,12 +1860,8 @@ impl crate::RawTransactionIngestStandardLogsSource {
|
||||
processing_frontier_sender: tokio::sync::watch::Sender<crate::RawTransactionIngestProcessingFrontierProjection>,
|
||||
shared: RawTransactionIngestSourceRuntimeShared,
|
||||
) -> ksp_core_lib::Result<()> {
|
||||
let RawTransactionIngestSourceRuntimeShared {
|
||||
continuity_contracts,
|
||||
global_hydration_registry,
|
||||
hydration_in_flight_limit,
|
||||
hydration_pending_limit,
|
||||
} = shared;
|
||||
let RawTransactionIngestSourceRuntimeShared { continuity_contracts, global_hydration_registry, hydration_in_flight_limit, hydration_pending_limit } =
|
||||
shared;
|
||||
let connected = tokio::select! {
|
||||
biased;
|
||||
_ = stop_receiver.changed() => {
|
||||
@@ -2336,9 +2310,7 @@ impl crate::RawTransactionIngestRuntimeResources {
|
||||
};
|
||||
let source_key = source.source_key();
|
||||
let _abort_handle = children.spawn(async move {
|
||||
let result = source
|
||||
.run(source_settings, source_stop_receiver, source_admission_sender, publisher, source_shared)
|
||||
.await;
|
||||
let result = source.run(source_settings, source_stop_receiver, source_admission_sender, publisher, source_shared).await;
|
||||
return (source_key, result);
|
||||
});
|
||||
}
|
||||
@@ -2564,9 +2536,7 @@ fn source_loss_continuity_range(error: &ksp_core_lib::Error) -> ksp_core_lib::Re
|
||||
}
|
||||
return match (start_slot, end_slot) {
|
||||
(std::option::Option::None, std::option::Option::None) => std::result::Result::Ok(std::option::Option::None),
|
||||
(std::option::Option::Some(start), std::option::Option::Some(end)) if end >= start => {
|
||||
std::result::Result::Ok(std::option::Option::Some((start, end)))
|
||||
},
|
||||
(std::option::Option::Some(start), std::option::Option::Some(end)) if end >= start => std::result::Result::Ok(std::option::Option::Some((start, end))),
|
||||
_ => std::result::Result::Err(crate::runtime_error("continuity.source_loss_range_invalid")),
|
||||
};
|
||||
}
|
||||
@@ -2584,10 +2554,7 @@ fn source_loss_is_reconcilable(error: &ksp_core_lib::Error) -> bool {
|
||||
}
|
||||
return matches!(
|
||||
context.value(),
|
||||
"source.configured_source_closed"
|
||||
| "source.continuity_gap_proven"
|
||||
| "source.replay_coverage_unproven"
|
||||
| "source.websocket_incident_unbounded"
|
||||
"source.configured_source_closed" | "source.continuity_gap_proven" | "source.replay_coverage_unproven" | "source.websocket_incident_unbounded"
|
||||
);
|
||||
});
|
||||
}
|
||||
@@ -2836,10 +2803,7 @@ fn validate_http_block_discovery_result(
|
||||
}
|
||||
let proven_end_slot = discovered.last().copied().map(|slot| return slot.min(end_slot));
|
||||
let produced_slots = discovered.iter().copied().take_while(|slot| return *slot <= end_slot).collect();
|
||||
std::result::Result::Ok(RawTransactionIngestHttpDiscoveryWindow {
|
||||
produced_slots,
|
||||
proven_end_slot,
|
||||
})
|
||||
std::result::Result::Ok(RawTransactionIngestHttpDiscoveryWindow { produced_slots, proven_end_slot })
|
||||
},
|
||||
};
|
||||
}
|
||||
@@ -3231,9 +3195,7 @@ fn standard_logs_live_source_key(
|
||||
return hasher.finalize().into();
|
||||
}
|
||||
|
||||
fn yellowstone_coverage_scope_fingerprint(
|
||||
request: &ksp_onchain_transport_lib::YellowstoneSubscribeRequest,
|
||||
) -> ksp_core_lib::Result<[u8; 32]> {
|
||||
fn yellowstone_coverage_scope_fingerprint(request: &ksp_onchain_transport_lib::YellowstoneSubscribeRequest) -> ksp_core_lib::Result<[u8; 32]> {
|
||||
let mut normalized = request.clone();
|
||||
normalized.set_commitment(std::option::Option::None);
|
||||
normalized.set_ping(std::option::Option::None);
|
||||
@@ -4049,11 +4011,7 @@ impl RawTransactionIngestProcessingFrontierReporter {
|
||||
}
|
||||
|
||||
fn observe_websocket_session_snapshot(&mut self, snapshot: ksp_onchain_transport_lib::WsSessionSnapshot) -> ksp_core_lib::Result<()> {
|
||||
return self.observe_websocket_continuity(
|
||||
map_websocket_source_state(snapshot.state()),
|
||||
snapshot.continuity_gap_count(),
|
||||
snapshot.overflow_count(),
|
||||
);
|
||||
return self.observe_websocket_continuity(map_websocket_source_state(snapshot.state()), snapshot.continuity_gap_count(), snapshot.overflow_count());
|
||||
}
|
||||
|
||||
fn observe_websocket_continuity(
|
||||
@@ -4094,19 +4052,15 @@ impl RawTransactionIngestProcessingFrontierReporter {
|
||||
}
|
||||
},
|
||||
std::option::Option::None => {
|
||||
let anchor = match crate::RawTransactionIngestWebSocketIncidentAnchor::new(
|
||||
start_slot,
|
||||
reconnect_total,
|
||||
overflow_total,
|
||||
saw_reconnect,
|
||||
saw_overflow,
|
||||
) {
|
||||
std::result::Result::Ok(value) => value,
|
||||
std::result::Result::Err(error) => {
|
||||
self.publish();
|
||||
return std::result::Result::Err(error);
|
||||
},
|
||||
};
|
||||
let anchor =
|
||||
match crate::RawTransactionIngestWebSocketIncidentAnchor::new(start_slot, reconnect_total, overflow_total, saw_reconnect, saw_overflow)
|
||||
{
|
||||
std::result::Result::Ok(value) => value,
|
||||
std::result::Result::Err(error) => {
|
||||
self.publish();
|
||||
return std::result::Result::Err(error);
|
||||
},
|
||||
};
|
||||
self.websocket_incident_anchor = std::option::Option::Some(anchor);
|
||||
},
|
||||
}
|
||||
@@ -4425,13 +4379,7 @@ impl RawTransactionIngestHydrationCoordinator {
|
||||
self.pending_signal_count -= pending.signals.len();
|
||||
for pending_signal in pending.signals {
|
||||
let signal_slot = pending_signal.signal.slot;
|
||||
let resolution = resolve_known_reference_hydration(
|
||||
hydration,
|
||||
settings,
|
||||
pending_signal.signal,
|
||||
pending_signal.received_at,
|
||||
&fetched.observed,
|
||||
);
|
||||
let resolution = resolve_known_reference_hydration(hydration, settings, pending_signal.signal, pending_signal.received_at, &fetched.observed);
|
||||
let resolution = match resolution {
|
||||
std::result::Result::Ok(value) => value,
|
||||
std::result::Result::Err(error) => return std::result::Result::Err(error),
|
||||
@@ -4639,16 +4587,9 @@ fn resolve_known_reference_hydration(
|
||||
std::result::Result::Err(error) => return std::result::Result::Err(error),
|
||||
};
|
||||
if let std::option::Option::Some(value) = ingress {
|
||||
return std::result::Result::Ok(RawTransactionIngestKnownReferenceHydrationResolution::Available(std::boxed::Box::new(
|
||||
value,
|
||||
)));
|
||||
return std::result::Result::Ok(RawTransactionIngestKnownReferenceHydrationResolution::Available(std::boxed::Box::new(value)));
|
||||
}
|
||||
let block_slot_supported = match http_role_supports_rpc_method(
|
||||
&hydration.http_pool,
|
||||
&hydration.hydration_role,
|
||||
"getBlock",
|
||||
hydration.network.as_str(),
|
||||
) {
|
||||
let block_slot_supported = match http_role_supports_rpc_method(&hydration.http_pool, &hydration.hydration_role, "getBlock", hydration.network.as_str()) {
|
||||
std::result::Result::Ok(value) => value,
|
||||
std::result::Result::Err(error) => return std::result::Result::Err(error),
|
||||
};
|
||||
|
||||
@@ -1,5 +1,5 @@
|
||||
// file: crates/ksp-worker-raw-transaction-ingest-lib/unit_tests/runtime_resources.rs
|
||||
// version: 29
|
||||
// version: 30
|
||||
|
||||
fn grpc_endpoint(cluster: &str) -> std::option::Option<ksp_onchain_transport_lib::YellowstoneGrpcEndpointSettings> {
|
||||
return grpc_endpoint_with_identity(cluster, "yellowstone-fixture", "fixture-provider");
|
||||
@@ -143,7 +143,7 @@ fn supervisor_contracts(
|
||||
let (scope, reference_bearing, block_material) = if *family == "full_ledger" {
|
||||
(crate::RawTransactionIngestCoverageScope::full_ledger_transactions(), false, true)
|
||||
} else {
|
||||
(crate::RawTransactionIngestCoverageScope::exact_source_scope(*family, [*fingerprint_byte; 32]), true, false)
|
||||
(crate::RawTransactionIngestCoverageScope::exact_source_scope(family, [*fingerprint_byte; 32]), true, false)
|
||||
};
|
||||
let capability = crate::RawTransactionIngestContinuityCapabilityDescriptor::new(
|
||||
[*source_key_byte; 32],
|
||||
|
||||
165
deltas/0.3.14/pre.008-fix.002.md
Normal file
165
deltas/0.3.14/pre.008-fix.002.md
Normal file
@@ -0,0 +1,165 @@
|
||||
<!-- file: deltas/0.3.14/pre.008-fix.002.md -->
|
||||
<!-- version: 1 -->
|
||||
|
||||
# Delta `0.3.14-pre.008-fix.002` — suppression de l'auto-deref explicite du test
|
||||
|
||||
## Base requise
|
||||
|
||||
```text
|
||||
0.3.14-pre.008-fix.001
|
||||
workspace.package.version = 0.3.14-pre.8.fix.1
|
||||
deltas/0.3.14/pre.008-fix.001.md présent
|
||||
```
|
||||
|
||||
## Objectif
|
||||
|
||||
Corriger strictement le dernier échec Clippy observé après `pre.008-fix.001`, sans modifier le code production ni la responsabilité fonctionnelle de `pre.008` :
|
||||
|
||||
```text
|
||||
supprimer clippy::explicit-auto-deref dans le helper de test supervisor_contracts
|
||||
préserver exactement les fixtures et assertions de pre.008
|
||||
ne pas avancer la health policy prévue en pre.009
|
||||
```
|
||||
|
||||
## Défaut observé
|
||||
|
||||
Le gate opérateur de `0.3.14-pre.008-fix.001` a produit :
|
||||
|
||||
```text
|
||||
cargo fmt --all : PASS
|
||||
cargo fmt --all -- --check : PASS
|
||||
audit Rust workspace rules : PASS
|
||||
audit Markdown tables : PASS
|
||||
cargo check --workspace : PASS
|
||||
cargo clippy --workspace --all-targets --all-features -- -D warnings : FAIL
|
||||
cargo test -p ksp-worker-raw-transaction-ingest-lib --all-targets --all-features : PASS, 139 unit tests et toutes les suites d'intégration
|
||||
```
|
||||
|
||||
Clippy signale dans `unit_tests/runtime_resources.rs` :
|
||||
|
||||
```text
|
||||
explicit-auto-deref
|
||||
exact_source_scope(*family, ...)
|
||||
help: use family
|
||||
```
|
||||
|
||||
## Cause
|
||||
|
||||
Dans la boucle sur `source_specs`, `family` est déjà une référence compatible avec le paramètre de `exact_source_scope`. Le déréférencement explicite `*family` est donc redondant et déclenche `clippy::explicit-auto-deref` sous `-D warnings`.
|
||||
|
||||
## Correction
|
||||
|
||||
Le helper de test utilise désormais directement `family` :
|
||||
|
||||
```text
|
||||
exact_source_scope(family, [*fingerprint_byte; 32])
|
||||
```
|
||||
|
||||
Aucun type production, aucune donnée de fixture et aucune décision de continuité ne changent.
|
||||
|
||||
## Fichiers ajoutés
|
||||
|
||||
```text
|
||||
deltas/0.3.14/pre.008-fix.002.md
|
||||
```
|
||||
|
||||
## Fichiers modifiés
|
||||
|
||||
```text
|
||||
Cargo.toml
|
||||
crates/ksp-worker-raw-transaction-ingest-lib/unit_tests/runtime_resources.rs
|
||||
```
|
||||
|
||||
## Fichiers supprimés
|
||||
|
||||
```text
|
||||
aucun
|
||||
```
|
||||
|
||||
## Version Cargo
|
||||
|
||||
Le fix modifie un fichier Rust de test ; conformément à `VER-ID-007` et `VER-ID-010` :
|
||||
|
||||
```text
|
||||
header Cargo.toml : 577 -> 578
|
||||
workspace.package.version : 0.3.14-pre.8.fix.1 -> 0.3.14-pre.8.fix.2
|
||||
```
|
||||
|
||||
Version de fichier :
|
||||
|
||||
```text
|
||||
unit_tests/runtime_resources.rs : 29 -> 30
|
||||
```
|
||||
|
||||
## Frontières préservées
|
||||
|
||||
```text
|
||||
aucun changement du code production
|
||||
aucun changement de TargetCoverage
|
||||
aucun changement de continuity frontier
|
||||
aucun changement de coverage epoch
|
||||
aucun changement de gap ledger
|
||||
aucun changement de source-loss classification
|
||||
aucun respawn Worker
|
||||
aucun nouveau scheduler ou task
|
||||
aucun changement Transport
|
||||
aucune nouvelle requête HTTP
|
||||
aucune nouvelle dépendance ou feature
|
||||
aucun accès Config
|
||||
aucun Job Backfill
|
||||
aucun backend Store physique
|
||||
aucune croissance de surface publique
|
||||
```
|
||||
|
||||
## Validations exécutées
|
||||
|
||||
Dans le sandbox de préparation :
|
||||
|
||||
```text
|
||||
python3 scripts/audit_rust_workspace_rules.py
|
||||
python3 scripts/audit_markdown_tables.py README.md RULES.md ROADMAP.md CHANGELOG.md docs prompts crates deltas
|
||||
inspection ciblée du helper supervisor_contracts
|
||||
comparaison exacte pre.008-fix.001 -> pre.008-fix.002
|
||||
contrôle du contenu de l'archive delta
|
||||
unzip -t de l'archive delta
|
||||
```
|
||||
|
||||
## Validations non exécutées
|
||||
|
||||
Le sandbox de préparation ne fournit pas le toolchain Cargo/Rust. Les gates suivants restent à exécuter côté opérateur :
|
||||
|
||||
```text
|
||||
cargo fmt --all
|
||||
cargo fmt --all -- --check
|
||||
cargo check --workspace
|
||||
cargo clippy --workspace --all-targets --all-features -- -D warnings
|
||||
cargo test -p ksp-worker-raw-transaction-ingest-lib --all-targets --all-features
|
||||
```
|
||||
|
||||
## Décisions prises
|
||||
|
||||
```text
|
||||
fix strict de pre.008
|
||||
aucun allow/expect lint
|
||||
aucune modification du code production
|
||||
aucune modification fonctionnelle de la réconciliation
|
||||
pre.009 reste la première tranche autorisée à modifier la health policy multi-source
|
||||
```
|
||||
|
||||
## Questions ouvertes
|
||||
|
||||
```text
|
||||
aucune pour ce fix
|
||||
```
|
||||
|
||||
## Gate opérateur après application
|
||||
|
||||
```bash
|
||||
cargo fmt --all
|
||||
cargo fmt --all -- --check
|
||||
python3 scripts/audit_rust_workspace_rules.py
|
||||
python3 scripts/audit_markdown_tables.py README.md RULES.md ROADMAP.md CHANGELOG.md docs prompts crates deltas
|
||||
cargo check --workspace
|
||||
cargo clippy --workspace --all-targets --all-features -- -D warnings
|
||||
cargo test -p ksp-worker-raw-transaction-ingest-lib --all-targets --all-features
|
||||
```
|
||||
Reference in New Issue
Block a user