v0.2.11-pre.003-fix.001

crates/ksp-offchain-transport-lib/unit_tests/http_admission.rs

@@ -1,5 +1,5 @@
 // file: crates/ksp-offchain-transport-lib/unit_tests/http_admission.rs
-// version: 1
+// version: 2
 
 #[test]
 fn fixed_admission_smooths_undocumented_burst_and_refills_deterministically() -> ksp_core_lib::Result<()> {
@@ -32,7 +32,7 @@ fn fixed_admission_smooths_undocumented_burst_and_refills_deterministically() ->
 }
 
 #[test]
-fn documented_burst_is_consumed_atomically_before_refill() -> ksp_core_lib::Result<()> {
+fn documented_burst_may_exceed_average_window_budget_and_is_consumed_atomically() -> ksp_core_lib::Result<()> {
     let policy = match crate::HttpAdmissionPolicy::fixed(1, std::time::Duration::from_secs(1), std::option::Option::Some(2)) {
         std::result::Result::Ok(value) => value,
         std::result::Result::Err(error) => return std::result::Result::Err(error),

crates/ksp-offchain-transport-lib/unit_tests/http_client.rs

@@ -1,5 +1,5 @@
 // file: crates/ksp-offchain-transport-lib/unit_tests/http_client.rs
-// version: 1
+// version: 2
 
 #[tokio::test]
 async fn rest_client_accepts_bounded_json_and_never_exposes_request_debug() -> ksp_core_lib::Result<()> {
@@ -36,6 +36,22 @@ async fn rest_client_accepts_bounded_json_and_never_exposes_request_debug() -> k
     return std::result::Result::Ok(());
 }
 
+#[test]
+fn https_request_builder_accepts_official_style_url_without_exposing_it() -> ksp_core_lib::Result<()> {
+    let mut request = match crate::HttpGetRequest::new_https("https://example.com/price") {
+        std::result::Result::Ok(value) => value,
+        std::result::Result::Err(error) => return std::result::Result::Err(error),
+    };
+    request.append_query_pair("symbol", "SOL/USD");
+    if let std::result::Result::Err(error) = request.insert_sensitive_header("x-api-key", "redaction-canary") {
+        return std::result::Result::Err(error);
+    }
+    let debug = format!("{request:?}");
+    assert!(!debug.contains("example.com"));
+    assert!(!debug.contains("redaction-canary"));
+    return std::result::Result::Ok(());
+}
+
 #[tokio::test]
 async fn rest_client_rejects_redirects_instead_of_following_them() -> ksp_core_lib::Result<()> {
     let server_result =