From e01fe88594fc8537573ecf4227831252ceddadd0 Mon Sep 17 00:00:00 2001 From: SinuS Von SifriduS Date: Thu, 3 Sep 2026 22:34:02 +0200 Subject: [PATCH] v0.3.8-pre.011-fix.001 --- Cargo.toml | 4 +-- .../tests/release_completeness.rs | 25 +++++++------ deltas/0.3.8/pre.011-fix.001.md | 35 +++++++++++++++++++ docs/validation/025-V0_3_8_STORE_DESK.md | 15 +++++++- 4 files changed, 66 insertions(+), 13 deletions(-) create mode 100644 deltas/0.3.8/pre.011-fix.001.md diff --git a/Cargo.toml b/Cargo.toml index c78fa8a..9248dca 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -1,12 +1,12 @@ # file: Cargo.toml -# version: 469 +# version: 470 [workspace] resolver = "3" members = ["crates/ksp-app-backfill-desk", "crates/ksp-app-config-desk", "crates/ksp-app-solprices-desk", "crates/ksp-app-store-desk", "crates/ksp-app-wallet-desk", "crates/ksp-config-lib", "crates/ksp-core-lib", "crates/ksp-interface-lib", "crates/ksp-job-api", "crates/ksp-job-backfill-lib", "crates/ksp-logging-lib", "crates/ksp-offchain-transport-lib", "crates/ksp-onchain-transport-lib", "crates/ksp-program-api", "crates/ksp-store-api", "crates/ksp-store-lib", "crates/ksp-store-postgres-lib", "crates/ksp-wallet-lib"] [workspace.package] -version = "0.3.8-pre.11" +version = "0.3.8-pre.11.fix.1" edition = "2024" license = "MIT" repository = "https://git.sasedev.com/Sasedev/khadhroony-solana-project" diff --git a/crates/ksp-app-store-desk/tests/release_completeness.rs b/crates/ksp-app-store-desk/tests/release_completeness.rs index d9c7045..103238c 100644 --- a/crates/ksp-app-store-desk/tests/release_completeness.rs +++ b/crates/ksp-app-store-desk/tests/release_completeness.rs @@ -1,5 +1,5 @@ // file: crates/ksp-app-store-desk/tests/release_completeness.rs -// version: 1 +// version: 2 //! Release-completeness firewall for the Store Desk V1 RAW surface. @@ -58,7 +58,12 @@ fn source_segment<'a>(source: &'a str, start: &str, end: &str) -> &'a str { fn handler_commands(source: &str) -> std::vec::Vec<&str> { let block = source_segment(source, "tauri::generate_handler![", "]);\n}"); - let mut commands = block.lines().map(str::trim).filter(|line| !line.is_empty()).map(|line| line.trim_end_matches(',')).collect::>(); + let mut commands = block + .lines() + .map(str::trim) + .filter(|line| return !line.is_empty()) + .map(|line| return line.trim_end_matches(',')) + .collect::>(); commands.sort_unstable(); return commands; } @@ -67,8 +72,8 @@ fn crate_modules(source: &str) -> std::vec::Vec<&str> { let mut modules = source .lines() .map(str::trim) - .filter(|line| line.starts_with("mod ") && line.ends_with(';')) - .map(|line| line.trim_start_matches("mod ").trim_end_matches(';')) + .filter(|line| return line.starts_with("mod ") && line.ends_with(';')) + .map(|line| return line.trim_start_matches("mod ").trim_end_matches(';')) .collect::>(); modules.sort_unstable(); return modules; @@ -78,10 +83,10 @@ fn visible_struct_names(source: &str) -> std::vec::Vec<&str> { let mut names = source .lines() .map(str::trim) - .filter(|line| line.starts_with("pub(crate) struct ")) - .filter_map(|line| line.strip_prefix("pub(crate) struct ")) - .filter_map(|line| line.split_whitespace().next()) - .map(|name| name.trim_end_matches('{')) + .filter(|line| return line.starts_with("pub(crate) struct ")) + .filter_map(|line| return line.strip_prefix("pub(crate) struct ")) + .filter_map(|line| return line.split_whitespace().next()) + .map(|name| return name.trim_end_matches('{')) .collect::>(); names.sort_unstable(); return names; @@ -203,8 +208,8 @@ fn pre_011_config_composition_is_exact_network_scoped_and_secret_free() { let profile_ids = profiles .iter() .map(|profile| match profile["profile_id"].as_str() { - std::option::Option::Some(value) => value, - std::option::Option::None => "", + std::option::Option::Some(value) => return value, + std::option::Option::None => return "", }) .collect::>(); assert_eq!(profile_ids, ["devnet", "mainnet", "testnet"]); diff --git a/deltas/0.3.8/pre.011-fix.001.md b/deltas/0.3.8/pre.011-fix.001.md new file mode 100644 index 0000000..57c53af --- /dev/null +++ b/deltas/0.3.8/pre.011-fix.001.md @@ -0,0 +1,35 @@ + + + +# v0.3.8-pre.011-fix.001 + +## Base + +- base obligatoire : `0.3.8-pre.011` ; +- type : correctif test/qualité ; +- `workspace.package.version = 0.3.8-pre.11.fix.1`. + +## Correction + +Le firewall `crates/ksp-app-store-desk/tests/release_completeness.rs` introduit en `pre.011` respecte désormais la règle KSP d'absence de retour implicite : + +- closures `filter`, `map` et `filter_map` avec `return` explicite ; +- branches du `match` terminal de la closure `profile_id` avec `return` explicite ; +- aucun changement des assertions, inventaires ou invariants vérifiés. + +## Hors scope + +Aucun changement runtime, frontend, DTO, IPC, Store API/façade, PostgreSQL, SQL, Config, migration ou capability Tauri. + +## Gate requis + +```bash +cargo fmt --all +python3 scripts/audit_rust_workspace_rules.py +python3 scripts/audit_markdown_tables.py README.md RULES.md ROADMAP.md CHANGELOG.md docs prompts crates deltas +cargo check --workspace +cargo clippy --workspace --all-targets +cargo test -p ksp-app-store-desk +cargo test -p ksp-store-lib +cargo check -p ksp-store-lib --no-default-features +``` diff --git a/docs/validation/025-V0_3_8_STORE_DESK.md b/docs/validation/025-V0_3_8_STORE_DESK.md index 5447722..abb143d 100644 --- a/docs/validation/025-V0_3_8_STORE_DESK.md +++ b/docs/validation/025-V0_3_8_STORE_DESK.md @@ -1,5 +1,5 @@ - + # Validation v0.3.8 — Store Desk V1 RAW @@ -822,3 +822,16 @@ cargo check -p ksp-store-lib --no-default-features: PASS Contrôles statiques d'assemblage : audits Rust/exports/Markdown propres avant création du delta. Le gate Cargo de `pre.011` reste à rejouer par l'opérateur. +## 39. `pre.011-fix.001` — conformité Clippy du firewall release-completeness + +Le gate opérateur de `0.3.8-pre.11` confirme que les audits KSP, `cargo check --workspace`, les 6 tests `release_completeness`, les suites Store Desk et Store façade sont verts. `cargo clippy --workspace --all-targets` reste cependant bloquant sur dix occurrences `clippy::implicit-return` dans le nouveau firewall `release_completeness.rs`. + +`pre.011-fix.001` corrige strictement ce défaut de test : + +- [X] les closures `filter`, `map` et `filter_map` ajoutées en `pre.011` utilisent des `return` explicites conformément aux règles Rust KSP ; +- [X] les deux branches du `match` terminal de la closure de collecte des `profile_id` utilisent également des `return` explicites ; +- [X] aucun invariant de release completeness n'est modifié ou relâché ; +- [X] aucun runtime, frontend, DTO, IPC, Store API/façade, PostgreSQL, SQL, Config ou capability Tauri n'est modifié ; +- [X] la version workspace devient `0.3.8-pre.11.fix.1` car un test Rust est modifié. + +Le gate Cargo du fix reste à rejouer après application du delta.