v0.3.2-pre.005

crates/ksp-store-lib/tests/feature_mismatch.rs

@@ -1,11 +1,11 @@
 // file: crates/ksp-store-lib/tests/feature_mismatch.rs
-// version: 3
+// version: 4
 
 #![warn(missing_docs)]
 #![deny(unreachable_pub)]
 #![forbid(unsafe_code)]
 
-//! Feature-selection canaries for known Store backends.
+//! Feature-selection and pre-I/O PostgreSQL failure canaries for the common Store facade.
 
 fn poll_ready<T>(future: impl std::future::Future<Output = T>) -> T {
     let mut future = std::boxed::Box::pin(future);
@@ -13,7 +13,7 @@ fn poll_ready<T>(future: impl std::future::Future<Output = T>) -> T {
     let mut context = std::task::Context::from_waker(waker);
     return match std::future::Future::poll(future.as_mut(), &mut context) {
         std::task::Poll::Ready(value) => value,
-        std::task::Poll::Pending => panic!("pre.003 Store feature-dispatch future unexpectedly became pending before any I/O exists"),
+        std::task::Poll::Pending => panic!("Store pre-I/O feature/config rejection unexpectedly became pending"),
     };
 }
 
@@ -24,9 +24,9 @@ fn valid_network() -> ksp_store_lib::RawNetworkId {
     };
 }
 
-fn settings() -> ksp_store_lib::StoreSettings {
+fn settings(connection_uri: &str) -> ksp_store_lib::StoreSettings {
     let postgres = ksp_store_lib::PostgresStoreSettings::new(
-        "postgresql://operator-supplied-sensitive-value",
+        connection_uri,
         ksp_store_lib::PostgresPoolSettings::default(),
         ksp_store_lib::PostgresTlsMode::Disabled,
         ksp_store_lib::PostgresBootstrapSettings::default(),
@@ -36,8 +36,8 @@ fn settings() -> ksp_store_lib::StoreSettings {
 
 #[cfg(not(feature = "postgres"))]
 #[test]
-fn pre_003_known_postgres_without_feature_returns_stable_error_before_io() {
-    let result = poll_ready(ksp_store_lib::Store::open(settings()));
+fn pre_005_known_postgres_without_feature_returns_stable_error_before_io() {
+    let result = poll_ready(ksp_store_lib::Store::open(settings("postgresql://operator-supplied-sensitive-value@localhost/ksp")));
     let error = result.err();
     assert_eq!(error.map(|value| return value.code()), std::option::Option::Some(ksp_store_lib::ERROR_CODE_BACKEND_NOT_COMPILED));
     return;
@@ -45,9 +45,11 @@ fn pre_003_known_postgres_without_feature_returns_stable_error_before_io() {
 
 #[cfg(feature = "postgres")]
 #[test]
-fn pre_003_compiled_postgres_path_refuses_to_fake_readiness_before_pre_005() {
-    let result = poll_ready(ksp_store_lib::Store::open(settings()));
+fn pre_005_compiled_postgres_rejects_malformed_uri_without_secret_leak_before_io() {
+    let secret_canary = "not-a-postgresql-uri-secret-canary";
+    let result = poll_ready(ksp_store_lib::Store::open(settings(secret_canary)));
     let error = result.err();
-    assert_eq!(error.map(|value| return value.code()), std::option::Option::Some(ksp_store_lib::ERROR_CODE_BACKEND_OPEN_FAILED));
+    assert_eq!(error.as_ref().map(|value| return value.code()), std::option::Option::Some(ksp_store_lib::ERROR_CODE_POSTGRES_CONFIG_INVALID));
+    assert!(!format!("{error:?}").contains(secret_canary));
     return;
 }