v0.3.7-pre.009-fix.002
This commit is contained in:
@@ -1,12 +1,12 @@
|
|||||||
# file: Cargo.toml
|
# file: Cargo.toml
|
||||||
# version: 432
|
# version: 433
|
||||||
|
|
||||||
[workspace]
|
[workspace]
|
||||||
resolver = "3"
|
resolver = "3"
|
||||||
members = ["crates/ksp-app-backfill-desk", "crates/ksp-app-config-desk", "crates/ksp-app-solprices-desk", "crates/ksp-app-wallet-desk", "crates/ksp-config-lib", "crates/ksp-core-lib", "crates/ksp-interface-lib", "crates/ksp-job-api", "crates/ksp-job-backfill-lib", "crates/ksp-logging-lib", "crates/ksp-offchain-transport-lib", "crates/ksp-onchain-transport-lib", "crates/ksp-program-api", "crates/ksp-store-api", "crates/ksp-store-lib", "crates/ksp-store-postgres-lib", "crates/ksp-wallet-lib"]
|
members = ["crates/ksp-app-backfill-desk", "crates/ksp-app-config-desk", "crates/ksp-app-solprices-desk", "crates/ksp-app-wallet-desk", "crates/ksp-config-lib", "crates/ksp-core-lib", "crates/ksp-interface-lib", "crates/ksp-job-api", "crates/ksp-job-backfill-lib", "crates/ksp-logging-lib", "crates/ksp-offchain-transport-lib", "crates/ksp-onchain-transport-lib", "crates/ksp-program-api", "crates/ksp-store-api", "crates/ksp-store-lib", "crates/ksp-store-postgres-lib", "crates/ksp-wallet-lib"]
|
||||||
|
|
||||||
[workspace.package]
|
[workspace.package]
|
||||||
version = "0.3.7-pre.9.fix.1"
|
version = "0.3.7-pre.9.fix.2"
|
||||||
edition = "2024"
|
edition = "2024"
|
||||||
license = "MIT"
|
license = "MIT"
|
||||||
repository = "https://git.sasedev.com/Sasedev/khadhroony-solana-project"
|
repository = "https://git.sasedev.com/Sasedev/khadhroony-solana-project"
|
||||||
|
|||||||
@@ -1,5 +1,5 @@
|
|||||||
// file: crates/ksp-app-backfill-desk/tests/desktop_security.rs
|
// file: crates/ksp-app-backfill-desk/tests/desktop_security.rs
|
||||||
// version: 11
|
// version: 12
|
||||||
|
|
||||||
//! Security and dependency-boundary checks for the Backfill Desk scaffold.
|
//! Security and dependency-boundary checks for the Backfill Desk scaffold.
|
||||||
|
|
||||||
@@ -248,7 +248,17 @@ fn pre_009_monitoring_projection_exposes_counters_and_codes_without_checkpoint_o
|
|||||||
for required in ["checkpoint_present", "contiguous_completed", "failure_code", "failure_domain", "sequence", "scope_kind"] {
|
for required in ["checkpoint_present", "contiguous_completed", "failure_code", "failure_domain", "sequence", "scope_kind"] {
|
||||||
assert!(dto.contains(required), "monitoring DTO missing required safe marker {required}");
|
assert!(dto.contains(required), "monitoring DTO missing required safe marker {required}");
|
||||||
}
|
}
|
||||||
for forbidden in ["address", "signature", "endpoint", "provider", "credential", "token", "checkpoint:", "payload", "raw_transaction"] {
|
for forbidden in [
|
||||||
assert!(!dto.contains(forbidden), "monitoring DTO leaks forbidden marker {forbidden}");
|
"pub(crate) address:",
|
||||||
|
"pub(crate) signature:",
|
||||||
|
"pub(crate) endpoint:",
|
||||||
|
"pub(crate) provider:",
|
||||||
|
"pub(crate) credential:",
|
||||||
|
"pub(crate) token:",
|
||||||
|
"pub(crate) checkpoint:",
|
||||||
|
"pub(crate) payload:",
|
||||||
|
"pub(crate) raw_transaction:",
|
||||||
|
] {
|
||||||
|
assert!(!dto.contains(forbidden), "monitoring DTO leaks forbidden field marker {forbidden}");
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
78
deltas/0.3.7/pre.009-fix.002.md
Normal file
78
deltas/0.3.7/pre.009-fix.002.md
Normal file
@@ -0,0 +1,78 @@
|
|||||||
|
<!-- file: deltas/0.3.7/pre.009-fix.002.md -->
|
||||||
|
<!-- version: 1 -->
|
||||||
|
|
||||||
|
# Delta `0.3.7-pre.009-fix.002` — canari sécurité monitoring
|
||||||
|
|
||||||
|
## 1. Base requise
|
||||||
|
|
||||||
|
```text
|
||||||
|
0.3.7-pre.009-fix.001
|
||||||
|
workspace.package.version = 0.3.7-pre.9.fix.1
|
||||||
|
```
|
||||||
|
|
||||||
|
## 2. Objectif
|
||||||
|
|
||||||
|
Corriger uniquement le faux positif du canari de sécurité `pre.009` sur `BackfillRunStatusDto`, sans modifier le monitoring latest-value ni aucun code de production.
|
||||||
|
|
||||||
|
## 3. Cause
|
||||||
|
|
||||||
|
Le canari cherchait les mots nus `address` et `signature` dans toute la déclaration source de `BackfillRunStatusDto`. La struct ne possède aucun champ de ce type, mais le commentaire de documentation de `scope_kind` contient légitimement la phrase indiquant que le scope est exposé sans payload d'adresse/signature.
|
||||||
|
|
||||||
|
Le test confondait donc documentation et surface sérialisée.
|
||||||
|
|
||||||
|
## 4. Correction
|
||||||
|
|
||||||
|
Les marqueurs interdits sont désormais des déclarations de champs exactes :
|
||||||
|
|
||||||
|
```text
|
||||||
|
pub(crate) address:
|
||||||
|
pub(crate) signature:
|
||||||
|
pub(crate) endpoint:
|
||||||
|
pub(crate) provider:
|
||||||
|
pub(crate) credential:
|
||||||
|
pub(crate) token:
|
||||||
|
pub(crate) checkpoint:
|
||||||
|
pub(crate) payload:
|
||||||
|
pub(crate) raw_transaction:
|
||||||
|
```
|
||||||
|
|
||||||
|
`checkpoint_present` reste autorisé et requis.
|
||||||
|
|
||||||
|
## 5. Version
|
||||||
|
|
||||||
|
```text
|
||||||
|
workspace.package.version = 0.3.7-pre.9.fix.2
|
||||||
|
label = 0.3.7-pre.009-fix.002
|
||||||
|
```
|
||||||
|
|
||||||
|
## 6. Fichiers modifiés
|
||||||
|
|
||||||
|
```text
|
||||||
|
Cargo.toml
|
||||||
|
crates/ksp-app-backfill-desk/tests/desktop_security.rs
|
||||||
|
docs/validation/024-V0_3_7_BACKFILL_DESK.md
|
||||||
|
```
|
||||||
|
|
||||||
|
## 7. Fichier ajouté
|
||||||
|
|
||||||
|
```text
|
||||||
|
deltas/0.3.7/pre.009-fix.002.md
|
||||||
|
```
|
||||||
|
|
||||||
|
## 8. Fichiers supprimés
|
||||||
|
|
||||||
|
Aucun.
|
||||||
|
|
||||||
|
## 9. Gate après application
|
||||||
|
|
||||||
|
```text
|
||||||
|
cargo fmt --all
|
||||||
|
python3 scripts/audit_rust_workspace_rules.py
|
||||||
|
python3 scripts/audit_markdown_tables.py README.md RULES.md ROADMAP.md CHANGELOG.md docs prompts crates deltas/0.3.7
|
||||||
|
cargo check --workspace
|
||||||
|
cargo clippy --workspace --all-targets
|
||||||
|
cargo test -p ksp-job-backfill-lib
|
||||||
|
cargo test -p ksp-app-backfill-desk
|
||||||
|
```
|
||||||
|
|
||||||
|
Aucun `cargo tree` requis : aucune dépendance ni feature Cargo n'est modifiée.
|
||||||
@@ -1,5 +1,5 @@
|
|||||||
<!-- file: docs/validation/024-V0_3_7_BACKFILL_DESK.md -->
|
<!-- file: docs/validation/024-V0_3_7_BACKFILL_DESK.md -->
|
||||||
<!-- version: 16 -->
|
<!-- version: 17 -->
|
||||||
|
|
||||||
# Validation v0.3.7 — Backfill Desk
|
# Validation v0.3.7 — Backfill Desk
|
||||||
|
|
||||||
@@ -463,3 +463,20 @@ Le correctif réutilise uniquement les helpers déjà possédés par chaque fich
|
|||||||
- [X] audits statiques Rust/Markdown rejoués dans l'environnement d'assemblage ;
|
- [X] audits statiques Rust/Markdown rejoués dans l'environnement d'assemblage ;
|
||||||
- [ ] replay opérateur `cargo fmt/check/clippy/test` du fix à exécuter ; aucun `cargo tree` requis car dépendances/features inchangées.
|
- [ ] replay opérateur `cargo fmt/check/clippy/test` du fix à exécuter ; aucun `cargo tree` requis car dépendances/features inchangées.
|
||||||
|
|
||||||
|
## 23. Correctif `pre.009-fix.002` — canari monitoring borné aux champs sérialisés
|
||||||
|
|
||||||
|
Le replay opérateur de `pre.009-fix.001` confirme que les audits Rust/Markdown, `cargo check --workspace`, Clippy, `ksp-job-backfill-lib` et les suites `desktop_contract` sont propres. Le seul échec restant est le canari `pre_009_monitoring_projection_exposes_counters_and_codes_without_checkpoint_or_business_payloads`.
|
||||||
|
|
||||||
|
Le DTO de production est conforme : il n'expose aucun champ adresse/signature. Le faux positif vient du canari, qui cherche les mots nus `address` et `signature` dans toute la source de `BackfillRunStatusDto`, y compris les commentaires de documentation. Or la documentation de `scope_kind` précise explicitement que ce champ est exposé « without address/signature payloads ».
|
||||||
|
|
||||||
|
Le correctif conserve le même niveau de sécurité mais cible désormais les déclarations de champs réellement sérialisés : `pub(crate) address:`, `pub(crate) signature:`, `pub(crate) endpoint:`, `pub(crate) provider:`, `pub(crate) credential:`, `pub(crate) token:`, `pub(crate) checkpoint:`, `pub(crate) payload:` et `pub(crate) raw_transaction:`. `checkpoint_present` reste explicitement autorisé.
|
||||||
|
|
||||||
|
### Gate du fix
|
||||||
|
|
||||||
|
- [X] aucun fichier de production, DTO, monitoring, frontend, Store, Transport ou Job n'est modifié ;
|
||||||
|
- [X] le canari n'interprète plus les doc-comments comme des champs IPC ;
|
||||||
|
- [X] les champs métier/sensibles restent interdits par leur déclaration exacte ;
|
||||||
|
- [X] `checkpoint_present` reste autorisé tandis que `pub(crate) checkpoint:` reste interdit ;
|
||||||
|
- [X] version Cargo synchronisée en `0.3.7-pre.9.fix.2` ;
|
||||||
|
- [X] audits statiques Rust/Markdown rejoués dans l'environnement d'assemblage ;
|
||||||
|
- [ ] replay opérateur `cargo fmt/check/clippy/test` du fix à exécuter ; aucun `cargo tree` requis car dépendances/features inchangées.
|
||||||
|
|||||||
Reference in New Issue
Block a user