From 4e2647cce1694e97fd99fa0481959f7ec6d5fe0d Mon Sep 17 00:00:00 2001 From: SinuS Von SifriduS Date: Thu, 3 Sep 2026 14:19:01 +0200 Subject: [PATCH] v0.3.8-pre.005-fix.002 --- Cargo.toml | 4 +- .../tests/dependency_boundary.rs | 6 +-- deltas/0.3.8/pre.005-fix.002.md | 38 +++++++++++++++++++ docs/validation/025-V0_3_8_STORE_DESK.md | 27 ++++++++++++- 4 files changed, 69 insertions(+), 6 deletions(-) create mode 100644 deltas/0.3.8/pre.005-fix.002.md diff --git a/Cargo.toml b/Cargo.toml index d9ae083..b1eb57e 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -1,12 +1,12 @@ # file: Cargo.toml -# version: 453 +# version: 454 [workspace] resolver = "3" members = ["crates/ksp-app-backfill-desk", "crates/ksp-app-config-desk", "crates/ksp-app-solprices-desk", "crates/ksp-app-store-desk", "crates/ksp-app-wallet-desk", "crates/ksp-config-lib", "crates/ksp-core-lib", "crates/ksp-interface-lib", "crates/ksp-job-api", "crates/ksp-job-backfill-lib", "crates/ksp-logging-lib", "crates/ksp-offchain-transport-lib", "crates/ksp-onchain-transport-lib", "crates/ksp-program-api", "crates/ksp-store-api", "crates/ksp-store-lib", "crates/ksp-store-postgres-lib", "crates/ksp-wallet-lib"] [workspace.package] -version = "0.3.8-pre.5.fix.1" +version = "0.3.8-pre.5.fix.2" edition = "2024" license = "MIT" repository = "https://git.sasedev.com/Sasedev/khadhroony-solana-project" diff --git a/crates/ksp-store-postgres-lib/tests/dependency_boundary.rs b/crates/ksp-store-postgres-lib/tests/dependency_boundary.rs index 3be0220..23a2d72 100644 --- a/crates/ksp-store-postgres-lib/tests/dependency_boundary.rs +++ b/crates/ksp-store-postgres-lib/tests/dependency_boundary.rs @@ -1,5 +1,5 @@ // file: crates/ksp-store-postgres-lib/tests/dependency_boundary.rs -// version: 27 +// version: 28 #![warn(missing_docs)] #![deny(unreachable_pub)] @@ -180,7 +180,7 @@ fn pre_005_raw_account_acquisition_is_atomic_idempotent_and_keeps_trait_impls_ou assert!(raw.contains(required), "missing private RAW account acquisition contract: {required}"); } assert!(runtime.contains("pub async fn persist_raw_account_acquisition")); - for forbidden in ["UPDATE ", "DELETE FROM", "ON CONFLICT DO UPDATE", " OFFSET "] { + for forbidden in ["UPDATE ", "DELETE FROM", "ON CONFLICT DO UPDATE"] { assert!(!raw.contains(forbidden), "pre.005 account module contains later/destructive scope: {forbidden}"); } for implementation in [ @@ -215,7 +215,7 @@ fn pre_006_raw_account_additional_observation_is_reference_guarded_cancellation_ assert!(raw.contains(required), "missing pre.006 additional-observation contract: {required}"); } assert!(runtime.contains("pub async fn record_raw_account_observation")); - for forbidden in ["UPDATE ", "DELETE FROM", "ON CONFLICT DO UPDATE", " OFFSET "] { + for forbidden in ["UPDATE ", "DELETE FROM", "ON CONFLICT DO UPDATE"] { assert!(!raw.contains(forbidden), "pre.006 account module contains later/destructive scope: {forbidden}"); } for implementation in [ diff --git a/deltas/0.3.8/pre.005-fix.002.md b/deltas/0.3.8/pre.005-fix.002.md new file mode 100644 index 0000000..9a31f73 --- /dev/null +++ b/deltas/0.3.8/pre.005-fix.002.md @@ -0,0 +1,38 @@ + + + +# Delta `0.3.8-pre.005-fix.002` — rescope des canaris Account `OFFSET` + +## Base requise + +Base directe attendue : `0.3.8-pre.005-fix.001`. + +## Objet + +Corriger exclusivement deux canaris historiques de dépendance PostgreSQL Account devenus trop larges après l'introduction du chemin d'inspection random-access de `pre.005`. + +## Modifications + +- `Cargo.toml` : version workspace `0.3.8-pre.5.fix.2` ; +- `crates/ksp-store-postgres-lib/tests/dependency_boundary.rs` : retrait de l'interdiction globale `OFFSET` des scopes historiques acquisition/additional-observation ; +- `docs/validation/025-V0_3_8_STORE_DESK.md` : consignation du gate opérateur, du live proof PostgreSQL 17 et de la justification du rescope. + +Les canaris dédiés pagination/hardening continuent d'exiger que les quatre statements Account cursor/keyset restent sans `OFFSET` et que les deux seules occurrences autorisées appartiennent aux statements d'inspection. + +## Hors scope + +Aucun changement de SQL, runtime PostgreSQL, Store API, façade Store, migration, capability, modèle, UI Desk ou protocole DataTables. + +## Validation attendue + +```bash +cargo fmt --all +python3 scripts/audit_rust_workspace_rules.py +python3 scripts/audit_markdown_tables.py README.md RULES.md ROADMAP.md CHANGELOG.md docs prompts crates deltas +cargo check --workspace +cargo clippy --workspace --all-targets +cargo test -p ksp-store-postgres-lib +cargo test -p ksp-store-lib +cargo check -p ksp-store-lib --no-default-features +cargo test -p ksp-store-api +``` diff --git a/docs/validation/025-V0_3_8_STORE_DESK.md b/docs/validation/025-V0_3_8_STORE_DESK.md index 8e709c6..77e6e7f 100644 --- a/docs/validation/025-V0_3_8_STORE_DESK.md +++ b/docs/validation/025-V0_3_8_STORE_DESK.md @@ -1,5 +1,5 @@ - + # Validation v0.3.8 — Store Desk V1 RAW @@ -417,3 +417,28 @@ KSP Store RawAccountState live proof: server major 17 test pre_009_real_postgres_raw_account_vertical_slice_is_atomic_concurrent_and_recoverable ... ok ``` +## 23. Gate opérateur `pre.005-fix.001` et ouverture de `pre.005-fix.002` + +Le rejeu opérateur sur `0.3.8-pre.5.fix.1` confirme que la restauration de la fixture Account inspection est correcte : `cargo fmt --all`, `cargo check --workspace`, `cargo clippy --workspace --all-targets`, les 69 tests unitaires PostgreSQL, `ksp-store-lib`, le mode `--no-default-features` et `ksp-store-api` compilent ou passent jusqu'au test d'intégration `dependency_boundary`. + +Deux canaris historiques Account restent cependant trop larges : + +```text +pre_005_raw_account_acquisition_is_atomic_idempotent_and_keeps_trait_impls_out_of_sql_module: FAIL +pre_006_raw_account_additional_observation_is_reference_guarded_cancellation_safe_and_keeps_destructive_scope_closed: FAIL +reason: raw_account.rs contient désormais OFFSET dans les deux statements d'inspection random-access +``` + +Ces canaris interdisaient `OFFSET` sur tout `raw_account.rs`, alors que depuis `pre.005` le fichier contient légitimement deux statements `INSPECT_ACCOUNT_STATES_*` avec `LIMIT/OFFSET`. Cette interdiction globale est obsolète. `pre.005-fix.002` retire uniquement `OFFSET` de leurs listes de scope interdit ; les garanties de pagination restent couvertes par : + +- `pre_007_raw_account_pagination_is_keyset_cursor_bound_and_policy_free`, qui exige que les quatre statements `LIST_ACCOUNT_STATES_*` et le cursor restent sans `OFFSET` ; +- `v0_3_8_pre_005_raw_account_keyset_sql_remains_offset_free_while_inspection_is_random_access`, qui exige exactement deux occurrences d'`OFFSET`, uniquement dans les deux statements d'inspection. + +Les interdictions destructives `UPDATE`, `DELETE FROM` et `ON CONFLICT DO UPDATE` restent inchangées dans les deux canaris historiques. Aucun SQL, runtime, contrat public, migration, capability ou comportement Store n'est modifié. + +Le live proof Account est de nouveau vert sur PostgreSQL 17 : + +```text +KSP Store RawAccountState live proof: server major 17 +test pre_009_real_postgres_raw_account_vertical_slice_is_atomic_concurrent_and_recoverable ... ok +```