v0.1.2-pre.004

crates/ksp-logging-lib/unit_tests/runtime.rs

@@ -1,5 +1,5 @@
 // file: crates/ksp-logging-lib/unit_tests/runtime.rs
-// version: 2
+// version: 3
 
 #[test]
 fn level_mapping_covers_all_ksp_levels() {
@@ -39,35 +39,52 @@ fn span_event_mapping_supports_disabled_timing_and_full_lifecycle() {
 }
 
 #[test]
-fn file_output_is_rejected_until_file_runtime_is_introduced() {
-    let settings = crate::LoggingSettings::new(
-        crate::LogFilterLevel::Info,
-        crate::SpanEvents::Off,
-        std::option::Option::None,
-        std::option::Option::Some(crate::FileSettings::new("logs", "ksp", crate::FileRotation::Daily)),
-    );
-    let result = super::prepare_runtime_layers(&settings);
-    assert!(result.is_err());
-    let error = match result {
-        std::result::Result::Ok(_) => return,
-        std::result::Result::Err(error) => error,
-    };
-    assert_eq!(error.code(), crate::ERROR_CODE_INVALID_SETTINGS);
+fn file_rotation_mapping_covers_supported_cadences() {
+    assert_eq!(super::map_file_rotation(crate::FileRotation::Never), tracing_appender::rolling::Rotation::NEVER);
+    assert_eq!(super::map_file_rotation(crate::FileRotation::Hourly), tracing_appender::rolling::Rotation::HOURLY);
+    assert_eq!(super::map_file_rotation(crate::FileRotation::Daily), tracing_appender::rolling::Rotation::DAILY);
 }
 
 #[test]
-fn console_runtime_keeps_takeover_filter_separate_from_formatter() {
+fn disabled_runtime_has_no_layers_or_outputs() {
+    let settings = crate::LoggingSettings::new(crate::LogFilterLevel::Info, crate::SpanEvents::Off, std::option::Option::None, std::option::Option::None);
+    let result = super::prepare_runtime(&settings);
+    assert!(result.is_ok());
+    let prepared = match result {
+        std::result::Result::Ok(prepared) => prepared,
+        std::result::Result::Err(_) => return,
+    };
+    assert!(prepared.layers.is_empty());
+    assert!(prepared.outputs.console.is_none());
+    assert!(prepared.outputs.file.is_none());
+}
+
+#[test]
+fn console_runtime_keeps_takeover_filter_separate_from_formatter_and_owns_guard() {
     let settings = crate::LoggingSettings::new(
         crate::LogFilterLevel::Info,
         crate::SpanEvents::Off,
         std::option::Option::Some(crate::ConsoleSettings::stdout()),
         std::option::Option::None,
     );
-    let result = super::prepare_runtime_layers(&settings);
+    let result = super::prepare_runtime(&settings);
     assert!(result.is_ok());
-    let layers = match result {
-        std::result::Result::Ok(layers) => layers,
+    let prepared = match result {
+        std::result::Result::Ok(prepared) => prepared,
         std::result::Result::Err(_) => return,
     };
-    assert_eq!(layers.len(), 2);
+    assert_eq!(prepared.layers.len(), 2);
+    assert!(prepared.outputs.console.is_some());
+    assert!(prepared.outputs.file.is_none());
+    assert_eq!(prepared.outputs.dropped_lines(), crate::DroppedLines::zero());
+}
+
+#[test]
+fn dropped_line_snapshots_add_saturating_by_sink() {
+    let first = crate::DroppedLines { console: usize::MAX, file: 4 };
+    let second = crate::DroppedLines { console: 1, file: 7 };
+    let combined = first.saturating_add(second);
+    assert_eq!(combined.console(), usize::MAX);
+    assert_eq!(combined.file(), 11);
+    assert_eq!(combined.total(), usize::MAX);
 }

crates/ksp-logging-lib/unit_tests/writer.rs

@@ -0,0 +1,30 @@
+// file: crates/ksp-logging-lib/unit_tests/writer.rs
+// version: 1
+
+#[test]
+fn ansi_writer_strips_csi_sequences() {
+    let mut writer = super::StripAnsiWriter::new(std::vec::Vec::<u8>::new());
+    let write_result = std::io::Write::write_all(&mut writer, b"before\x1b[31mred\x1b[0mafter");
+    assert!(write_result.is_ok());
+    assert_eq!(writer.into_inner(), b"beforeredafter");
+}
+
+#[test]
+fn ansi_writer_preserves_state_across_split_writes() {
+    let mut writer = super::StripAnsiWriter::new(std::vec::Vec::<u8>::new());
+    let first = std::io::Write::write_all(&mut writer, b"a\x1b[");
+    let second = std::io::Write::write_all(&mut writer, b"32mb");
+    assert!(first.is_ok());
+    assert!(second.is_ok());
+    assert_eq!(writer.into_inner(), b"ab");
+}
+
+#[test]
+fn ansi_writer_strips_osc_sequences_terminated_by_bell_or_st() {
+    let mut writer = super::StripAnsiWriter::new(std::vec::Vec::<u8>::new());
+    let first = std::io::Write::write_all(&mut writer, b"a\x1b]0;title\x07b");
+    let second = std::io::Write::write_all(&mut writer, b"c\x1b]8;;https://example.invalid\x1b\\d");
+    assert!(first.is_ok());
+    assert!(second.is_ok());
+    assert_eq!(writer.into_inner(), b"abcd");
+}